bereng commented on a change in pull request #870:
URL: https://github.com/apache/cassandra/pull/870#discussion_r572602851
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
##########
@@ -269,6 +276,63 @@ public void testCreateAlterKeyspaces() throws Throwable
"max_threshold", "32")));
}
+ @Test
+ public void testCreateAlterKeyspacesRFWarnings() throws Throwable
+ {
+ requireNetwork();
+ Thread.sleep(1000); // Hack: requireNetwork() will clear warnings
async so give some time to complete
Review comment:
I disagree here. A person debugging the test will be under the
impression the poll guarantees the 0 warnings which is not true. A sleep
signals a _best effort_ to workaround an async issue as in other tests. The
'expected 0 warnings at the start of the test' is implicit in the assert
expecting only 1 warning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
