adelapena commented on a change in pull request #870:
URL: https://github.com/apache/cassandra/pull/870#discussion_r572884430
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
##########
@@ -269,6 +276,63 @@ public void testCreateAlterKeyspaces() throws Throwable
"max_threshold", "32")));
}
+ @Test
+ public void testCreateAlterKeyspacesRFWarnings() throws Throwable
+ {
+ requireNetwork();
+ Thread.sleep(1000); // Hack: requireNetwork() will clear warnings
async so give some time to complete
Review comment:
Polling seems like a good way to avoid the test becoming flaky. However,
I'm still unable to reproduce the failure when the current wait is absent. I
have removed the wait
[here](https://github.com/adelapena/cassandra/commits/CASSANDRA-16296-review-3)
and run both the individual test and the entire suite/class in the multiplexer:
*
[method](https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/690/)
*
[class](https://jenkins-dse.build.dsinternal.org/view/Parameterized/job/parameterized-testall/691/)
It's 100 runs for the class and 200 runs for the method, without any
failure. Running them locally a few dozen times doesn't produce any failure
either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
