ekaterinadimitrova2 commented on a change in pull request #870:
URL: https://github.com/apache/cassandra/pull/870#discussion_r573759185
##########
File path: test/unit/org/apache/cassandra/schema/CreateTableValidationTest.java
##########
@@ -72,7 +69,7 @@ public void testCreateKeyspaceTableWarning() throws
IOException
try (SimpleClient client =
newSimpleClient(ProtocolVersion.CURRENT).connect(false))
{
- String createKeyspace = "CREATE KEYSPACE createkswarning%d WITH
REPLICATION={'class':'org.apache.cassandra.locator.NetworkTopologyStrategy','datacenter1':'2'}";
+ String createKeyspace = "CREATE KEYSPACE createkswarning%d WITH
REPLICATION={'class':'org.apache.cassandra.locator.NetworkTopologyStrategy','datacenter1':'1'}";
Review comment:
Then why don't we just change the assertions around the warnings? So we
don't change the idea of the test but assert on the right flow - like 1 warning
and it is that specific one and not others
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
