bereng commented on a change in pull request #870:
URL: https://github.com/apache/cassandra/pull/870#discussion_r574270782



##########
File path: 
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
##########
@@ -269,6 +276,63 @@ public void testCreateAlterKeyspaces() throws Throwable
                                   "max_threshold", "32")));
     }
 
+    @Test
+    public void testCreateAlterKeyspacesRFWarnings() throws Throwable
+    {
+        requireNetwork();
+        Thread.sleep(1000); // Hack: requireNetwork() will clear warnings 
async so give some time to complete

Review comment:
       > doesn't have to be for !warns.emptybut for whatever signals that 
requireNetwork has finished
   
   That is _exactly_ the point I was trying to make. Thx for summarizing it. I 
am happy to either remove the Sleep or leave it. You guys let me know what you 
prefer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to