smiklosovic commented on a change in pull request #875:
URL: https://github.com/apache/cassandra/pull/875#discussion_r574457151
##########
File path: src/java/org/apache/cassandra/io/util/FileUtils.java
##########
@@ -66,7 +66,7 @@
import static org.apache.cassandra.utils.Throwables.maybeFail;
import static org.apache.cassandra.utils.Throwables.merge;
-public final class FileUtils
+public class FileUtils
Review comment:
It does not matter to have it final as it already has private
constructor so it can not be extended anyway as extender can not call super and
it just blocks mocking as it can not deal with finals.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
