krummas commented on a change in pull request #875:
URL: https://github.com/apache/cassandra/pull/875#discussion_r580882552
##########
File path: src/java/org/apache/cassandra/io/sstable/format/SSTableReader.java
##########
@@ -2276,8 +2276,24 @@ public static SSTableReader
moveAndOpenSSTable(ColumnFamilyStore cfs, Descriptor
throw new RuntimeException(msg);
}
- logger.info("Renaming new SSTable {} to {}", oldDescriptor,
newDescriptor);
- SSTableWriter.rename(oldDescriptor, newDescriptor, components);
+ if (copyData)
+ {
+ try
+ {
+ logger.info("Hardlinking new SSTable {} to {}", oldDescriptor,
newDescriptor);
+ SSTableWriter.hardlink(oldDescriptor, newDescriptor,
components);
+ }
+ catch (Throwable t)
Review comment:
catch `FSWriteError` or what is actually thrown by
`SSTableWriter.hardlink`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
