jacek-lewandowski commented on a change in pull request #892:
URL: https://github.com/apache/cassandra/pull/892#discussion_r582607713
##########
File path: src/java/org/apache/cassandra/gms/Gossiper.java
##########
@@ -2128,9 +2143,25 @@ public boolean waitForSchemaAgreement(long maxWait,
TimeUnit unit, BooleanSuppli
}
}
- public boolean haveMajorVersion3Nodes()
+ /**
+ * Returns {@code true} only if the information about the version of each
node in the cluster is available and
+ * ALL the nodes are on 4.0 (regardless of the patch version).
+ */
+ public boolean hasMajorVersion3Nodes()
{
- return haveMajorVersion3NodesMemoized.get();
+
+ return upgradeInProgressPossible ||
isUpgradingFromVersionLowerThan(CassandraVersion.CASSANDRA_4_0);
Review comment:
Yes, it is desired. `ColumnFilter` no longer uses this method but it is
used in some other places which I didn't touch or analysed. Thus, I'd like to
keep the original behaviour for those cases. I'll actually tweak it a bit for
the cases where we upgrading from say 4.0 to 4.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
