adelapena commented on a change in pull request #892:
URL: https://github.com/apache/cassandra/pull/892#discussion_r583126857
##########
File path: src/java/org/apache/cassandra/db/filter/ColumnFilter.java
##########
@@ -74,25 +78,34 @@
// null. If false, then _fetched_ == _queried_ and we only store _queried_.
final boolean fetchAllRegulars;
+ // This flag can be only set when fetchAllRegulars is set. When
fetchAllRegulars is set and queried==null then
+ // it is implied to be true. The flag when set allows for interpreting the
column filter in the same way as it was
+ // interpreted by pre 4.0 Cassandra versions (3.4 ~ 4.0), that is, we
fetch all columns (both regulars and static)
+ // but we query only some of them. This allows for proper behaviour during
upgrades.
+ final boolean fetchAllStatics;
Review comment:
I think that with the new changes in `ColumnFilterTest` this one and
`queried` below can be `private`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
