yifan-c commented on a change in pull request #1080:
URL: https://github.com/apache/cassandra/pull/1080#discussion_r656544519
##########
File path: src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java
##########
@@ -499,13 +503,12 @@ void waitForFinalSync()
}
}
- void waitForSync(int position, Timer waitingOnCommit)
+ void waitForSync(int position)
{
while (lastSyncedOffset < position)
{
- WaitQueue.Signal signal = waitingOnCommit != null ?
-
syncComplete.register(waitingOnCommit.time()) :
- syncComplete.register();
Review comment:
A general question... why does `AbstractCommitLogService#awaitSyncAt`
(called by `PeriodicCommitLogService`) still register the timer context with
the syncComplete?
##########
File path: src/java/org/apache/cassandra/metrics/CommitLogMetrics.java
##########
@@ -23,6 +23,8 @@
import org.apache.cassandra.db.commitlog.AbstractCommitLogService;
import org.apache.cassandra.db.commitlog.AbstractCommitLogSegmentManager;
+import java.util.concurrent.TimeUnit;
Review comment:
unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
