maedhroz commented on a change in pull request #1080:
URL: https://github.com/apache/cassandra/pull/1080#discussion_r656552609
##########
File path: src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java
##########
@@ -499,13 +503,12 @@ void waitForFinalSync()
}
}
- void waitForSync(int position, Timer waitingOnCommit)
+ void waitForSync(int position)
{
while (lastSyncedOffset < position)
{
- WaitQueue.Signal signal = waitingOnCommit != null ?
-
syncComplete.register(waitingOnCommit.time()) :
- syncComplete.register();
Review comment:
`PeriodicCommitLogService` doesn't block writes under normal conditions,
so I left that behavior alone. The big motivating factor for this change was
making sure that when "batch" or "group" CL are in use, the metric data points
correspond to single writes (and vise-versa). It probably wouldn't be harmful
to do it for "periodic" as well, but it also doesn't buy much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
