blerer commented on a change in pull request #1083:
URL: https://github.com/apache/cassandra/pull/1083#discussion_r660327845
##########
File path:
test/distributed/org/apache/cassandra/distributed/test/SinglePartitionReadCommandTest.java
##########
@@ -144,4 +144,47 @@ public void
testPartitionWithStaticColumnsOnlyOnOneNodeAndColumnDeletionOnTheOth
assertRows(cluster.coordinator(2).execute(withKeyspace("SELECT
DISTINCT s1 FROM %s.tbl WHERE pk=2"), ConsistencyLevel.ALL));
}
}
+
+ @Test
+ public void testNonCompactTableWithEmptyRowOnBothNodes() throws Throwable
Review comment:
Both nodes have an empty row: a row with only primary key. The column
deletion is simply used to create the empty row.
##########
File path: src/java/org/apache/cassandra/db/SinglePartitionReadCommand.java
##########
@@ -1033,7 +1033,15 @@ private ClusteringIndexNamesFilter
reduceFilter(ClusteringIndexNamesFilter filte
SearchIterator<Clustering, Row> searchIter =
result.searchIterator(columnFilter(), false);
- PartitionColumns columns = columnFilter().fetchedColumns();
+ // According to the CQL semantics a row exists if at least one of its
columns is not null (including the primary key columns).
+ // Having the queried columns not null is unfortunately not enough to
prove that a row exists has some column deletion
Review comment:
It was a typo I mean `as` and not `has`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
