blerer commented on a change in pull request #1083:
URL: https://github.com/apache/cassandra/pull/1083#discussion_r661415716



##########
File path: test/unit/org/apache/cassandra/cql3/KeyCacheCqlTest.java
##########
@@ -262,7 +262,7 @@ private void test2iKeyCachePaths() throws Throwable
         long hits = metrics.hits.getCount();
         long requests = metrics.requests.getCount();
         assertEquals(0, hits);
-        assertEquals(210, requests);
+        assertEquals(206, requests);

Review comment:
       The expected number for queries without indices = previous number of 
request + Sum for each request of (1 (the row is only in one sstable) + number 
of bloom filter false positive for the request)
   
   For indices queries you have to add the index query + the number of bloom 
filter false positive for index query
   
   I will try to find a way to make it explicite in the test. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to