michaelsembwever commented on a change in pull request #1051: URL: https://github.com/apache/cassandra/pull/1051#discussion_r675893851
########## File path: src/java/org/apache/cassandra/audit/AuditLogOptionsCompositeData.java ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.audit; + +import java.util.HashMap; +import java.util.Map; +import javax.management.openmbean.CompositeData; +import javax.management.openmbean.CompositeDataSupport; +import javax.management.openmbean.CompositeType; +import javax.management.openmbean.OpenDataException; +import javax.management.openmbean.OpenType; +import javax.management.openmbean.SimpleType; + +import org.apache.cassandra.config.ParameterizedClass; + +public class AuditLogOptionsCompositeData Review comment: > it looks weird to depend in StorageService on some stuff from the nodetool package. Good point. So two things here now come to mind… 1) why are we putting `getAuditLogOptions()` into StorageService? Would it be cleaner we a `AuditLogManagerMBean` ? 2) how do we code this to make it easy for the virtual table to be added? WRT (2) the codebase is going to find new precedences to accommodate the transition period of JMX and Virtual Tables, and it would be nice if each didn't involve a verbose copy of code. (I'm not thinking about any high level compatibility layer as was discussed on the ML, just code with a small amount of effort that makes sense.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
