smiklosovic commented on a change in pull request #1051: URL: https://github.com/apache/cassandra/pull/1051#discussion_r675901243
########## File path: src/java/org/apache/cassandra/audit/AuditLogOptionsCompositeData.java ########## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.audit; + +import java.util.HashMap; +import java.util.Map; +import javax.management.openmbean.CompositeData; +import javax.management.openmbean.CompositeDataSupport; +import javax.management.openmbean.CompositeType; +import javax.management.openmbean.OpenDataException; +import javax.management.openmbean.OpenType; +import javax.management.openmbean.SimpleType; + +import org.apache.cassandra.config.ParameterizedClass; + +public class AuditLogOptionsCompositeData Review comment: That is actually a good idea to create separate MBean for that. I might do that. I really appreciate your willingness to help here in regards of upcoming changes related to virtual tables and similar, however, honestly, and I do not want to look like I am rushing this, but just for the sake of the simplicity and getting rid of this, I would go with the easy path, not trying to come up with anything new, until we prepare CEP where all these things will be written down more clearly. I am afraid that anything we come up with here will be rewritten anyway when that virtual tables CEP arrives. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
