blerer commented on a change in pull request #1117:
URL: https://github.com/apache/cassandra/pull/1117#discussion_r678454428
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/entities/VirtualTableTest.java
##########
@@ -88,17 +89,45 @@ public void apply(PartitionUpdate update)
}
}
+ private abstract static class TruncatableVirtualTable extends
AbstractVirtualTable
+ {
+ private boolean isTruncated = false;
+
+ TruncatableVirtualTable(TableMetadata metadata)
+ {
+ super(metadata);
+ }
+
+ @Override
+ public DataSet data()
+ {
+ if (isTruncated)
Review comment:
I have seen case in the past where people introduced a bug in the code
the tests failed to catch it. So, I was wondering if there were some scenarios
that we could miss where the test could give us a false positive. I agree with
you that the implementation is straight forward today but being paranoiac, I
wished to make the test a bit more bullet proof. The counter approach is pretty
simple and give us an extra security at low cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
