blerer commented on a change in pull request #1117:
URL: https://github.com/apache/cassandra/pull/1117#discussion_r678459044
##########
File path:
test/unit/org/apache/cassandra/cql3/validation/entities/VirtualTableTest.java
##########
@@ -88,17 +89,45 @@ public void apply(PartitionUpdate update)
}
}
+ private abstract static class TruncatableVirtualTable extends
AbstractVirtualTable
+ {
+ private boolean isTruncated = false;
Review comment:
Sorry for being confusing. You are right, with the way the test is done
today there is no concurrency race.
I have seen in the past some tests where we decided to switch from `execute`
to `executeNet` to do some extra testing for authorization for example. In such
case the code will become mutltithreaded and people might miss the fact that
the test was not intended to support concurrency initially. To prevent such a
problem, I would have made the variable `volatile` to be on the safe side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
