smiklosovic commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r678512811
##########
File path: src/java/org/apache/cassandra/service/StorageService.java
##########
@@ -5786,35 +5786,40 @@ public void disableAuditLog()
public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException
{
- enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers);
+ enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers,
+ Integer.MIN_VALUE, null, null, Long.MIN_VALUE,
Integer.MIN_VALUE, null);
}
public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories,
String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException
{
- loggerName = loggerName != null ? loggerName :
DatabaseDescriptor.getAuditLoggingOptions().logger.class_name;
-
- Preconditions.checkNotNull(loggerName, "cassandra.yaml did not have
logger in audit_logging_option and not set as parameter");
-
Preconditions.checkState(FBUtilities.isAuditLoggerClassExists(loggerName),
"Unable to find AuditLogger class: "+loggerName);
Review comment:
it will default to BinAuditLogger (default implementation) when this is
not set and if it is set but the class does not exist, it will throw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
