smiklosovic commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r678530970
##########
File path: src/java/org/apache/cassandra/audit/AuditLogFilter.java
##########
@@ -31,12 +30,12 @@
private static ImmutableSet<String> EMPTY_FILTERS = ImmutableSet.of();
- private final ImmutableSet<String> excludedKeyspaces;
- private final ImmutableSet<String> includedKeyspaces;
- private final ImmutableSet<String> excludedCategories;
- private final ImmutableSet<String> includedCategories;
- private final ImmutableSet<String> includedUsers;
- private final ImmutableSet<String> excludedUsers;
+ public final ImmutableSet<String> excludedKeyspaces;
+ public final ImmutableSet<String> includedKeyspaces;
+ public final ImmutableSet<String> excludedCategories;
+ public final ImmutableSet<String> includedCategories;
+ public final ImmutableSet<String> includedUsers;
+ public final ImmutableSet<String> excludedUsers;
Review comment:
I made it _package protected_ as well as the whole class (plus I made it
final). It does not need to be protected when that class is never going to be
extended anway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
