belliottsmith commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r685913781
##########
File path: src/java/org/apache/cassandra/transport/CQLMessageHandler.java
##########
@@ -163,7 +163,7 @@ protected boolean processOneContainedMessage(ShareableBytes
bytes, Limit endpoin
if (throwOnOverload)
{
- if (DatabaseDescriptor.getNativeTransportRateLimitingEnabled() &&
!requestRateLimiter.tryReserve())
+ if (DatabaseDescriptor.getNativeTransportRateLimitingEnabled() &&
requestRateLimiter.reserveAndGetWaitMicros() > 0)
Review comment:
I think you've replaced a conditional reservation with an unconditional
one, so that these overloads still count towards the number of requests we're
processing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
