belliottsmith commented on a change in pull request #1045:
URL: https://github.com/apache/cassandra/pull/1045#discussion_r685920436
##########
File path: src/java/org/apache/cassandra/transport/CQLMessageHandler.java
##########
@@ -405,8 +463,40 @@ protected boolean
processFirstFrameOfLargeMessage(IntactFrame frame, Limit endpo
// max CQL message size defaults to 256mb, so should be safe to
downcast
int messageSize = Ints.checkedCast(header.bodySizeInBytes);
receivedBytes += buf.remaining();
-
+
LargeMessage largeMessage = new LargeMessage(header);
+
+ if (DatabaseDescriptor.getNativeTransportRateLimitingEnabled())
+ {
+ long waitLengthMicros =
requestRateLimiter.reserveAndGetWaitMicros();
Review comment:
Shouldn't this be conditional also, for throwOnOverload? Otherwise we
may find ourselves trapped in a spiral of discarding messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
