k-rus opened a new pull request #152:
URL: https://github.com/apache/cassandra-dtest/pull/152
This commit fixes few unexpected behaviors, which were:
1. If any test class is marked with `resource_intensive`, then all tests
in the file were treated as resource intensive.
2. If one test class is marked with `vnodes` and another test class is
marked with `no_vnodes` in the same file, then all tests were
skipped in the file.
3. If a test run is executed with the argument
`--only-resource-intensive-tests` and there is no sufficient
resources for resource intensive tests, then no tests were executed.
Thus it was necessary to provide `-force-resource-intensive-tests`
in addition.
The unexpected behaviors 1 and 2 are due to marking all tests in a
file if any class is assigned the mark.
As the result of this commit:
- Marks on other classes in the file do not affect a test, which is
not marked and neither its class. This is also applied to upgrade
tests, so the code is simplified and behavior is unified.
- `--only-resource-intensive-tests` does not require sufficient
resources any more, so specifying it will execute only resource
intensive tests independently on available resources.
Since after the fix marking needs to be done on every class in the
file if tests are expected to be marked, the files with upgrade tests
are fixed to mark each included test class if at least one class is
marked.
The unit tests of `is_shippable` from `conftest.py` are changed to test
calculating skipping conditions from provided mocked configurations
instead of shipping if conditions are satisfied or not, which required
to change the underlying implementation. The unit tests are also
rewritten to be parameterized and it covers now all possible meaningful
test cases.
patch by Ruslan Fomkin; reviewed by ... for CASSANDRA-16841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
