k-rus commented on a change in pull request #152:
URL: https://github.com/apache/cassandra-dtest/pull/152#discussion_r702710177
##########
File path: upgrade_tests/paging_test.py
##########
@@ -188,6 +188,7 @@ def random_txt(text):
assert_lists_equal_ignoring_order(pf.all_data(), expected_data,
sort_key='value')
[email protected]_test
Review comment:
Thank you for pointing it. Actually marking `BasePagingTester` is not
needed, since it inherits form `UpgradeTester`, which is already marked. My
main concern is that the marking becomes implicit. I don't know if it will be
confusing or not, while believe developers will have intention that all tests
are marked as upgrade tests in this folder. I can try to clarify in
`upgrade_tests/README.md` that using `UpgradeTester` is enough.
I tested that it works in `pytest`, however the readme instructions use
`nosetests` to run upgrade tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
