smiklosovic commented on a change in pull request #1027:
URL: https://github.com/apache/cassandra/pull/1027#discussion_r686620657



##########
File path: src/java/org/apache/cassandra/security/SSLFactory.java
##########
@@ -351,9 +194,16 @@ public static void 
checkCertFilesForHotReloading(EncryptionOptions.ServerEncrypt
         if (!isHotReloadingInitialized)
             throw new IllegalStateException("Hot reloading functionality has 
not been initialized.");
 
-        logger.debug("Checking whether certificates have been updated {}", 
hotReloadableFiles);
+        logger.debug("Checking whether certificates have been updated {} and 
{}",
+                     
serverOpts.sslContextFactoryInstance.getClass().getName(), 
clientOpts.sslContextFactoryInstance.getClass().getName());
+
+        boolean serverSslContextShouldReload = serverOpts == null ? false :

Review comment:
       Both of these might be simplified similarly as for hot loading files 
case, like serverOpts != null && serverOpts...shouldReload();




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to