maulin-vasavada commented on a change in pull request #1027:
URL: https://github.com/apache/cassandra/pull/1027#discussion_r687275632
##########
File path: src/java/org/apache/cassandra/security/SSLFactory.java
##########
@@ -351,9 +194,16 @@ public static void
checkCertFilesForHotReloading(EncryptionOptions.ServerEncrypt
if (!isHotReloadingInitialized)
throw new IllegalStateException("Hot reloading functionality has
not been initialized.");
- logger.debug("Checking whether certificates have been updated {}",
hotReloadableFiles);
+ logger.debug("Checking whether certificates have been updated {} and
{}",
+
serverOpts.sslContextFactoryInstance.getClass().getName(),
clientOpts.sslContextFactoryInstance.getClass().getName());
+
+ boolean serverSslContextShouldReload = serverOpts == null ? false :
+
serverOpts.sslContextFactoryInstance.shouldReload();
+
+ boolean clientSslContextShouldReload = clientOpts == null ? false :
+
clientOpts.sslContextFactoryInstance.shouldReload();
- if
(hotReloadableFiles.stream().anyMatch(HotReloadableFile::shouldReload))
+ if (serverSslContextShouldReload || clientSslContextShouldReload)
{
logger.info("SSL certificates have been updated. Reseting the ssl
contexts for new connections.");
Review comment:
Sorry about it. Most of these were from the SSLFactory's code but this
is a good time to make it better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
