ekaterinadimitrova2 commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r686895296
##########
File path: src/java/org/apache/cassandra/audit/AuditLogManager.java
##########
@@ -148,6 +167,8 @@ public synchronized void disableAuditLog()
unregisterAsListener();
IAuditLogger oldLogger = auditLogger;
auditLogger = new NoOpAuditLogger(Collections.emptyMap());
+ // when we disable audit logging, we should also reset options so we
return default ones (from cassandra.yml)
+ auditLogOptions = DatabaseDescriptor.getAuditLoggingOptions();
Review comment:
I don't see a reason not to change the getAuditLogOptions to the way FQL
does it. I think this will make it also more clear to people. Now when you look
at getAuditLogOptions you will know exactly in what case what is returned.
Reset in disable is not wrong(it obviously leads to the same behavior) but it
is not self-explanatory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
