ekaterinadimitrova2 commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r686306253
##########
File path: src/java/org/apache/cassandra/audit/AuditLogManager.java
##########
@@ -148,6 +167,8 @@ public synchronized void disableAuditLog()
unregisterAsListener();
IAuditLogger oldLogger = auditLogger;
auditLogger = new NoOpAuditLogger(Collections.emptyMap());
+ // when we disable audit logging, we should also reset options so we
return default ones (from cassandra.yml)
+ auditLogOptions = DatabaseDescriptor.getAuditLoggingOptions();
Review comment:
I might have forgotten something as it's been a week since I was looking
into the details but if we read directly from the cassandra.yaml, why do we
have to do reset when we disable? And next time when we enable it just loads
the default ones on enable? I see that is what the fql tool does. What do I
miss? The stop method of the fqltool does not do any reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
