smiklosovic commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r690676106



##########
File path: src/java/org/apache/cassandra/service/StorageService.java
##########
@@ -5786,38 +5786,53 @@ public void disableAuditLog()
         logger.info("Auditlog is disabled");
     }
 
+    @Deprecated
     public void enableAuditLog(String loggerName, String includedKeyspaces, 
String excludedKeyspaces, String includedCategories, String excludedCategories,
                                String includedUsers, String excludedUsers) 
throws ConfigurationException, IllegalStateException
     {
-        enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces, 
excludedKeyspaces, includedCategories, excludedCategories, includedUsers, 
excludedUsers);
+        enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces, 
excludedKeyspaces, includedCategories, excludedCategories, includedUsers, 
excludedUsers,
+                       Integer.MIN_VALUE, null, null, Long.MIN_VALUE, 
Integer.MIN_VALUE, null);
+    }
+
+    public void enableAuditLog(String loggerName, String includedKeyspaces, 
String excludedKeyspaces, String includedCategories, String excludedCategories,
+                               String includedUsers, String excludedUsers, 
Integer maxArchiveRetries, Boolean block, String rollCycle,
+                               Long maxLogSize, Integer maxQueueWeight, String 
archiveCommand) throws ConfigurationException, IllegalStateException
+    {
+        enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces, 
excludedKeyspaces, includedCategories, excludedCategories, includedUsers, 
excludedUsers,
+                       maxArchiveRetries, block, rollCycle, maxLogSize, 
maxQueueWeight, archiveCommand);
     }
 
+    @Deprecated
     public void enableAuditLog(String loggerName, Map<String, String> 
parameters, String includedKeyspaces, String excludedKeyspaces, String 
includedCategories, String excludedCategories,

Review comment:
       that one does not accept Map, for tooling like JConsole, there is not 
any way how to invoke a method if it accepts Map, it is not invokable there.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to