ekaterinadimitrova2 commented on a change in pull request #1051:
URL: https://github.com/apache/cassandra/pull/1051#discussion_r690669594
##########
File path: src/java/org/apache/cassandra/service/StorageServiceMBean.java
##########
@@ -790,8 +790,15 @@ public StageConcurrency(int corePoolSize, int
maximumPoolSize)
/** Clears the history of clients that have connected in the past **/
void clearConnectionHistory();
public void disableAuditLog();
- public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories, String includedUsers, String
excludedUsers) throws ConfigurationException;
- public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
String includedUsers, String excludedUsers) throws ConfigurationException;
+ public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers,
Integer maxArchiveRetries, Boolean block, String rollCycle,
+ Long maxLogSize, Integer maxQueueWeight, String
archiveCommand) throws ConfigurationException, IllegalStateException;
+
+ public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException;
+
+ public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException;
Review comment:
I think that will be done with alias. For reference, I found this good
example today
https://issues.apache.org/jira/browse/CASSANDRA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17400403#comment-17400403
##########
File path: src/java/org/apache/cassandra/service/StorageService.java
##########
@@ -5786,38 +5786,53 @@ public void disableAuditLog()
logger.info("Auditlog is disabled");
}
+ @Deprecated
public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException
{
- enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers);
+ enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers,
+ Integer.MIN_VALUE, null, null, Long.MIN_VALUE,
Integer.MIN_VALUE, null);
+ }
+
+ public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers,
Integer maxArchiveRetries, Boolean block, String rollCycle,
+ Long maxLogSize, Integer maxQueueWeight, String
archiveCommand) throws ConfigurationException, IllegalStateException
+ {
+ enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers,
+ maxArchiveRetries, block, rollCycle, maxLogSize,
maxQueueWeight, archiveCommand);
}
+ @Deprecated
public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories,
Review comment:
There is one unused enableAuditLog method that is not deprecated and I
am not sure why, can you, please, double check?
##########
File path: src/java/org/apache/cassandra/service/StorageService.java
##########
@@ -5786,38 +5786,53 @@ public void disableAuditLog()
logger.info("Auditlog is disabled");
}
+ @Deprecated
public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
String includedUsers, String excludedUsers)
throws ConfigurationException, IllegalStateException
{
- enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers);
+ enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers,
+ Integer.MIN_VALUE, null, null, Long.MIN_VALUE,
Integer.MIN_VALUE, null);
+ }
+
+ public void enableAuditLog(String loggerName, String includedKeyspaces,
String excludedKeyspaces, String includedCategories, String excludedCategories,
+ String includedUsers, String excludedUsers,
Integer maxArchiveRetries, Boolean block, String rollCycle,
+ Long maxLogSize, Integer maxQueueWeight, String
archiveCommand) throws ConfigurationException, IllegalStateException
+ {
+ enableAuditLog(loggerName, Collections.emptyMap(), includedKeyspaces,
excludedKeyspaces, includedCategories, excludedCategories, includedUsers,
excludedUsers,
+ maxArchiveRetries, block, rollCycle, maxLogSize,
maxQueueWeight, archiveCommand);
}
+ @Deprecated
public void enableAuditLog(String loggerName, Map<String, String>
parameters, String includedKeyspaces, String excludedKeyspaces, String
includedCategories, String excludedCategories,
Review comment:
Ok, so just add a comment on commit so that people don't have to ask,
please. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
