dcapwell commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r702139788
##########
File path: src/java/org/apache/cassandra/db/ReadCommand.java
##########
@@ -632,6 +654,84 @@ private void maybeDelayForTesting()
}
}
+ private UnfilteredPartitionIterator
withQuerySizeTracking(UnfilteredPartitionIterator iterator)
Review comment:
I didn't go with `withResponseSizeTracking` as the response may be
smaller than the size we compute; this blocks on total allocated rather than
the final need.
> amount of stuff we have to materialize on-heap
yep, that is mostly it. Freeing isn't free and is async when GC feels like
it, so large materialized reads could cause unstable GCs
##########
File path: src/java/org/apache/cassandra/db/ReadCommand.java
##########
@@ -632,6 +654,84 @@ private void maybeDelayForTesting()
}
}
+ private UnfilteredPartitionIterator
withQuerySizeTracking(UnfilteredPartitionIterator iterator)
Review comment:
I didn't go with `withResponseSizeTracking` as the response may be
smaller than the size we compute; this blocks on total allocated rather than
the final need.
> amount of stuff we have to materialize on-heap
yep, that is mostly it. Freeing isn't free and is async when GC feels like
it, so large materialized reads could cause unstable GCs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
