dcapwell commented on a change in pull request #1180:
URL: https://github.com/apache/cassandra/pull/1180#discussion_r702144981
##########
File path: src/java/org/apache/cassandra/db/ReadCommand.java
##########
@@ -632,6 +654,84 @@ private void maybeDelayForTesting()
}
}
+ private UnfilteredPartitionIterator
withQuerySizeTracking(UnfilteredPartitionIterator iterator)
+ {
+ if (!trackWarnings ||
SchemaConstants.isSystemKeyspace(metadata().keyspace)) // exclude internal
keyspaces
Review comment:
> are we guaranteed that trackWarnings will be properly visible to that
other thread (a ReadStage thread)?
My gut tells me there will be a bug but won't know till I test. Will look
closer at your test and try to replicate
The bigger question is will we propagate the warnings, and I feel like we
won't (it was annoying to get scans working... and that is single threaded!).
If we cross thread-boundaries I believe we will load information, so the repair
will act as if track_warnings was disabled (even if the field is correct as I
made sure cloning propagates the field)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
