josh-mckenzie commented on pull request #1183: URL: https://github.com/apache/cassandra/pull/1183#issuecomment-915216140
> My concern with the current patch is that we keep the overiding values in a separate location (`AuthProperties`) instead of updating them in `DatabaseDescriptor` as it is usually done. If somebody use the `Settings` system view to look at the current settings he will see the default setting and not the updated ones. That can be confusing in my opinion. Totally agree; this was an artifact of me taking an old approach and pushing and pulling it until I had a good grasp of where the static state was initialized during clientInitialization. I've pushed up another commit that makes Config the canonical owner of auth read and write CL state and keeps the String <-> ConsistencyLevel conversion barrier between DBD and Config, removing all state tracking from AuthProperties. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
