maedhroz commented on pull request #1180: URL: https://github.com/apache/cassandra/pull/1180#issuecomment-915251018
+1 on the latest raft of commits Also, I think my concerns about the safety of the thread locals and `trackWarnings` publishing look unfounded at this point. Thanks for the additional investigation there. It looks like the only thing that's really left to resolve is what to do w/ the cases where we can propagate multiple (sometimes identical) warnings to the client. I think there are probably defensible approaches for both reporting a single warning (given that in most cases the client can't do much more with multiple errors than one) and reporting all of them but differentiating the messages (for instance if one comes from a digest read and another a full data read). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
