josh-mckenzie commented on pull request #1213: URL: https://github.com/apache/cassandra/pull/1213#issuecomment-938799746
Ok @azotcsit and @sumanth-pasupuleti . Rebased on top of CEP-10, rewrote the load all and load table logic so table and global limits should be respected now, updated unit tests, and tidied up a bunch of stuff. I've been trying to change as little as possible up to this point as this is code that's been running at scale in production for years and I've been trying to balance the desire to let battle-tested code lie vs. cleaning it up for our maintainability going forward, but you pointing out the break in the loading logic flaw @azotcsit was kind of the last straw for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
