josh-mckenzie commented on a change in pull request #1213:
URL: https://github.com/apache/cassandra/pull/1213#discussion_r726522575
##########
File path: test/unit/org/apache/cassandra/config/DatabaseDescriptorRefTest.java
##########
@@ -126,6 +126,7 @@
"org.apache.cassandra.exceptions.ConfigurationException",
"org.apache.cassandra.exceptions.RequestValidationException",
"org.apache.cassandra.exceptions.CassandraException",
+ "org.apache.cassandra.exceptions.InvalidRequestException",
Review comment:
When changes to the code-base cause new classes to be instantiated on
offline tool startup, the DBDRefTests will fail as they're hard-coded to only
allow a certain subset of classes to start up so offline tools don't spin up
entire Cassandra nodes thanks the static state we have scattered about.
These three classes show up after the change here to Denylist things, so
they need to be added as valid classes so the test passes. Now, we can debate
whether it's ok to have these 2 exceptions and the ReplicaCollection show up
thanks to our changes (for instance: ReplicaPlans in RangeCommands.java due to
sufficientLiveNodesForSelectStar placement) - but I think these three are
pretty innocuous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
