bereng commented on a change in pull request #1380:
URL: https://github.com/apache/cassandra/pull/1380#discussion_r785731203
##########
File path: src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java
##########
@@ -495,6 +495,9 @@ private static boolean valueAppliesTo(CollectionType<?>
type, Iterator<Cell<?>>
if (value == null)
return !iter.hasNext();
+ if(operator.isContains() || operator.isContainsKey())
+ return valueAppliesTo(type, iter,
value.get(ProtocolVersion.CURRENT), operator);
Review comment:
Here you branch off to a logic specific to the CONTAINS operators, could
we rename those methods to indicate that? just like the list/set/map methods
i.e.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
