bereng commented on a change in pull request #1380:
URL: https://github.com/apache/cassandra/pull/1380#discussion_r823382799
##########
File path: src/java/org/apache/cassandra/cql3/conditions/ColumnCondition.java
##########
@@ -531,6 +534,25 @@ private static boolean setOrListAppliesTo(AbstractType<?>
type, Iterator<Cell<?>
return operator == Operator.EQ || operator == Operator.LTE ||
operator == Operator.GTE;
}
+ private static boolean valueAppliesTo(Iterator<Cell<?>> iter,
ByteBuffer value, boolean appliesToSetOrMapKeys)
+ {
+ while(iter.hasNext())
+ {
+ // for lists and map values we use the cell value; for sets
and map keys we use the cell name
+ ByteBuffer cellValue = appliesToSetOrMapKeys ?
iter.next().path().get(0) : iter.next().buffer();
+ int comparison = BytesType.instance.compare(cellValue, value);
Review comment:
All instances where the comparison `!= 0` in the class call
`evaluateComparisonWithOperator()`. So for consistency and in case the logic in
that method changed (add logging, update a metric, God knows,...) I would use
it:
```
int res = type.compare(cellValue, value);
return res == 0 ? 0 : evaluateComparisonWithOperator(res, EQ);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
