ErickRamirezAU commented on a change in pull request #90:
URL: https://github.com/apache/cassandra-website/pull/90#discussion_r795448526



##########
File path: site-content/source/modules/ROOT/pages/development/documentation.adoc
##########
@@ -8,7 +8,7 @@
 The official Cassandra documentation lives in the project's git
 repository.
 We use a static site generator, http://www.antora.org/[Antora], to create 
pages hosted at
-{site-url}/doc/latest/[cassandra.apache.org].
+{site-url}doc/latest/[cassandra.apache.org].

Review comment:
       Nope, definitely doesn't work. 🙂
   
   `{site-url}` doesn't get rendered at all. This is what it looks like in both 
[production](https://cassandra.apache.org/_/development/documentation.html) and 
[staging](https://cassandra.staged.apache.org/_/development/documentation.html):
   
   ```
   The official Cassandra documentation lives in the project’s git repository. \
     We use a static site generator, Antora, to create pages hosted at 
//doc/latest/[cassandra.apache.org].
   ```
   
   I've spent 2 hours last week just on this single issue and couldn't find any 
other way of making it work. I finally spoke to the Antora experts and they 
confirmed that since the Doc pages are not asciidoc, Antora doesn't know how to 
render `{site-url}` and so the link to the docs have to be hardcoded.
   
   Feel free to have a look at 
http://18.192.24.126:9000/_/development/documentation.html where I have your PR 
built/staged. Cheers! 🍻




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to