ErickRamirezAU commented on a change in pull request #90:
URL: https://github.com/apache/cassandra-website/pull/90#discussion_r814541055



##########
File path: 
site-content/source/modules/ROOT/pages/blog/Join-Cassandra-GSoC-2021.adoc
##########
@@ -17,7 +17,7 @@ The Apache Software Foundation (ASF) has been a 
https://community.apache.org/gso
 == How to Get Involved
 
 ==== Getting Started
-The best way to get started if you’re new to Apache Cassandra is to get 
acquainted by reading the {site-url}/doc/latest/[documentation,window=_blank] 
and setting up a local {site-url}/doc/latest/development/ide.html[development 
environment,window=_blank]. Play around with a locally running instance via 
{site-url}/doc/latest/tools/cqlsh.html?highlight=cqlsh[cqlsh,window=_blank] and 
{site-url}/doc/latest/tools/nodetool/nodetool.html[nodetool,window=_blank] to 
get a feel for how to use the database. If you run into problems or roadblocks 
during this exercise, don’t be shy to ask questions via the 
xref:community.adoc[community channels] like the developers 
mailto:[email protected][mailing list] or the #cassandra-dev 
channel on the https://s.apache.org/slack-invite[ASF Slack,window=_blank].
+The best way to get started if you’re new to Apache Cassandra is to get 
acquainted by reading the 
https://cassandra.apache.org/doc/latest/[documentation,window=_blank] and 
setting up a local xref:development/ide.adoc[development 
environment,window=_blank]. Play around with xref:quickstart.adoc[a locally 
running instance using Docker,window=_blank] to get a feel for how to use the 
database. If you run into problems or roadblocks during this exercise, don’t be 
shy to ask questions via the xref:community.adoc[community channels] like the 
developers mailto:[email protected][mailing list] or the 
#cassandra-dev channel on the https://s.apache.org/slack-invite[ASF 
Slack,window=_blank].

Review comment:
       I'm sorry I made a mistake in my previous review. The URL for 
`/doc/latest` doesn't need to be hardcoded, just needs the `link:` macro.
   
   ```suggestion
   The best way to get started if you’re new to Apache Cassandra is to get 
acquainted by reading the link:/doc/latest/[documentation,window=_blank] and 
setting up a local xref:development/ide.adoc[development 
environment,window=_blank]. Play around with xref:quickstart.adoc[a locally 
running instance using Docker,window=_blank] to get a feel for how to use the 
database. If you run into problems or roadblocks during this exercise, don’t be 
shy to ask questions via the xref:community.adoc[community channels] like the 
developers mailto:[email protected][mailing list] or the 
#cassandra-dev channel on the https://s.apache.org/slack-invite[ASF 
Slack,window=_blank].
   ```

##########
File path: site-content/source/modules/ROOT/pages/development/documentation.adoc
##########
@@ -8,7 +8,7 @@
 The official Cassandra documentation lives in the project's git
 repository.
 We use a static site generator, http://www.antora.org/[Antora], to create 
pages hosted at
-{site-url}/doc/latest/[cassandra.apache.org].
+{site-url}doc/latest/[cassandra.apache.org].

Review comment:
       BTW the link on line 22 will also need to be fixed:
   
   ```
   Feel free to take a look at http://cassandra.apache.org/docs[existing 
documents] to get a better idea how we structure our documents.
   ```

##########
File path: site-content/source/modules/ROOT/pages/community.adoc
##########
@@ -331,7 +331,7 @@ https://www.apache.org/theapacheway/index.html[The Apache 
Way,window=blank]
 
 [openblock, float75 full-800]
 ----------
-Contributors are individuals who contribute patches—source code, 
documentation, help on mailing lists, website—to Apache projects. While 
contributors do not have a specific governance role, they are crucial to the 
project’s success. Read the docs to learn how to 
{site-url}doc/latest/development/index.html[contribute to 
Cassandra,window=blank], and review our 
https://cwiki.apache.org/confluence/display/CASSANDRA/Apache+Cassandra+Project+Governance[governance,window=blank]
 page to understand how we vote on code contributions.
+Contributors are individuals who contribute patches—source code, 
documentation, help on mailing lists, website—to Apache projects. While 
contributors do not have a specific governance role, they are crucial to the 
project’s success. Read the docs to learn how to 
{site-url}doc/latest/development/index.html[contribute to 
Cassandra,window=blank], and review our 
https://cwiki.apache.org/confluence/display/CASSANDRA/Cassandra+Project+Governance[governance,window=blank]
 page to understand how we vote on code contributions.

Review comment:
       There’s a merge conflict with this page which needs to be resolved:
   
   ```
   <<<<<<< trunk
   Contributors are individuals who contribute patches—source code, 
documentation, help on mailing lists, website—to Apache projects. While 
contributors do not have a specific governance role, they are crucial to the 
project’s success. Read the docs to learn how to 
{site-url}doc/latest/development/index.html[contribute to 
Cassandra,window=blank], and review our 
https://cwiki.apache.org/confluence/display/CASSANDRA/Cassandra+Project+Governance[governance,window=blank]
 page to understand how we vote on code contributions.
   =======
   Contributors are individuals who contribute patches—source code, 
documentation, help on mailing lists, website—to Apache projects. While 
contributors do not have a specific governance role, they are crucial to the 
project’s success. Read the docs to learn how to 
link:{site-url}_/development/index.html[contribute to Cassandra,window=blank], 
and review our 
https://cwiki.apache.org/confluence/display/CASSANDRA/Apache+Cassandra+Project+Governance[governance,window=blank]
 page to understand how we vote on code contributions.
   >>>>>>> trunk
   ```
   
   It should be this:
   
   ```suggestion
   Contributors are individuals who contribute patches—source code, 
documentation, help on mailing lists, website—to Apache projects. While 
contributors do not have a specific governance role, they are crucial to the 
project’s success. Read the docs to learn how to 
xref:/development/index.adoc[contribute to Cassandra,window=blank], and review 
our 
https://cwiki.apache.org/confluence/display/CASSANDRA/Cassandra+Project+Governance[governance,window=blank]
 page to understand how we vote on code contributions.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to