dcapwell commented on a change in pull request #31:
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/31#discussion_r797815346
##########
File path:
src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -64,6 +64,16 @@
private int datadirCount = 3;
private final List<Rack> racks = new ArrayList<>();
private boolean finalised;
+ private int tokenCount = getDefaultTokenCount();
+ private boolean allowVnodes = true;
+
+ protected int getDefaultTokenCount() {
+ String key = "cassandra.dtest.num_tokens";
+ String value = System.getProperty(key);
+ if (value == null)
+ value = System.getenv(key.replace(".", "_").toUpperCase());
+ return value == null ? 1 : Integer.parseInt(value);
+ }
Review comment:
https://the-asf.slack.com/archives/CK23JSY2K/p1643747361709199
mck asked we rely on system properties via ant rather than environment
variable, but figure I will keep environment variable anyways as its useful
outside of Apache CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
