dcapwell commented on a change in pull request #31:
URL:
https://github.com/apache/cassandra-in-jvm-dtest-api/pull/31#discussion_r799781750
##########
File path:
src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -64,6 +64,16 @@
private int datadirCount = 3;
private final List<Rack> racks = new ArrayList<>();
private boolean finalised;
+ private int tokenCount = getDefaultTokenCount();
+ private boolean allowVnodes = true;
Review comment:
> Is the assumption here that most tests should Just Work with vnodes
enabled
yes
##########
File path:
src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -64,6 +64,16 @@
private int datadirCount = 3;
private final List<Rack> racks = new ArrayList<>();
private boolean finalised;
+ private int tokenCount = getDefaultTokenCount();
+ private boolean allowVnodes = true;
Review comment:
> Is the assumption here that most tests should Just Work with vnodes
enabled
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]