smiklosovic commented on a change in pull request #1249:
URL: https://github.com/apache/cassandra/pull/1249#discussion_r799293288
##########
File path: pylib/cqlshlib/copyutil.py
##########
@@ -1405,8 +1405,8 @@ def __init__(self, params, target):
super(ChildProcess, self).__init__(target=target)
self.inpipe = params['inpipe']
self.outpipe = params['outpipe']
- self.inmsg = None # must be initialized after fork on Windows
- self.outmsg = None # must be initialized after fork on Windows
+ self.inmsg = None
Review comment:
I am not sure about this, I admit I know 0 about threading in Python.
But by mere looking at it, I do not think this is a big deal anyway. Maybe
@bowensong may shed some light on this? But I would personaly not touch it and
just moved along.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
