smiklosovic commented on a change in pull request #1249:
URL: https://github.com/apache/cassandra/pull/1249#discussion_r800045631
##########
File path: pylib/cqlshlib/copyutil.py
##########
@@ -1405,8 +1405,8 @@ def __init__(self, params, target):
super(ChildProcess, self).__init__(target=target)
self.inpipe = params['inpipe']
self.outpipe = params['outpipe']
- self.inmsg = None # must be initialized after fork on Windows
- self.outmsg = None # must be initialized after fork on Windows
+ self.inmsg = None
Review comment:
hi @bowensong , thanks for the very detailed answer. I can revert the
removal of the comment or rather change it in such a way it would mention a
ticket the work (or rather investigation into this matter) would be addressed
in. I honestly think the refactoring of this would prolong / delay the merging
of this branch unncessarilly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
