frankgh commented on a change in pull request #1438:
URL: https://github.com/apache/cassandra/pull/1438#discussion_r799526047
##########
File path:
src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java
##########
@@ -171,7 +172,10 @@ public boolean execute(Set<InetAddressAndPort> peers,
Function<InetAddressAndPor
{
// dc -> missing peer host addresses
Map<String, List<String>> peersDown =
acks.getMissingPeers().stream()
-
.collect(groupingBy(peerToDatacenter::get,
+ .collect(groupingBy(peer
-> {
+
String dc = peerToDatacenter.get(peer);
+
return dc != null ? dc :
StringUtils.defaultString(getDatacenterSource.apply(peer), "unknown");
Review comment:
Yeah, I was trying to avoid calling the snitch. I pushed an update. Java
9 has an API to do what I'm trying to do here:
https://docs.oracle.com/javase/9/docs/api/java/util/Objects.html#requireNonNullElseGet-T-java.util.function.Supplier-
However, I'm not sure if apache commons or guava offer something similar. I
will spend some time looking for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
