smiklosovic commented on a change in pull request #1438:
URL: https://github.com/apache/cassandra/pull/1438#discussion_r799543307
##########
File path:
src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java
##########
@@ -171,7 +172,10 @@ public boolean execute(Set<InetAddressAndPort> peers,
Function<InetAddressAndPor
{
// dc -> missing peer host addresses
Map<String, List<String>> peersDown =
acks.getMissingPeers().stream()
-
.collect(groupingBy(peerToDatacenter::get,
+ .collect(groupingBy(peer
-> {
+
String dc = peerToDatacenter.get(peer);
+
return dc != null ? dc :
StringUtils.defaultString(getDatacenterSource.apply(peer), "unknown");
Review comment:
I think it has to compile on Java 8 for sure. I recently hit a bug when
a developer used `Set.of` which is not in 8 but in 11 (hence 9 maybe?). So
please code against Java 8 in general as that is the lowest common denominator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
