bowensong commented on a change in pull request #1249:
URL: https://github.com/apache/cassandra/pull/1249#discussion_r800050053
##########
File path: pylib/cqlshlib/copyutil.py
##########
@@ -1405,8 +1405,8 @@ def __init__(self, params, target):
super(ChildProcess, self).__init__(target=target)
self.inpipe = params['inpipe']
self.outpipe = params['outpipe']
- self.inmsg = None # must be initialized after fork on Windows
- self.outmsg = None # must be initialized after fork on Windows
+ self.inmsg = None
Review comment:
@smiklosovic I agree. Refactoring this shouldn't be a part of this as it
will unnecessarily prolong / delay this PR. The work is ideally done in a
separate PR. I personally would prefer a comment added here and make it clear
why the code was written in this way, and link to a JIRA ticket for refactoring
this. Or, at minimal, a comment saying the code was written in this way for
Windows `fork()` compatibility and is no longer necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
