dcapwell commented on a change in pull request #1335:
URL: https://github.com/apache/cassandra/pull/1335#discussion_r802095902
##########
File path: src/java/org/apache/cassandra/config/EncryptionOptions.java
##########
@@ -342,7 +348,7 @@ public Boolean isOptional()
* is probably a bad idea.
* @param optional value to set
*/
- public void setOptional(boolean optional) {
+ public void setOptional(Boolean optional) {
Review comment:
`boolean` doesn't match the `get` method, so java's POJO logic doesn't
pair them together; setting `Boolean` solves this, we box anyways, but now
allow `null`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
