dcapwell commented on a change in pull request #1335:
URL: https://github.com/apache/cassandra/pull/1335#discussion_r804185940
##########
File path: src/java/org/apache/cassandra/config/Converters.java
##########
@@ -132,7 +145,7 @@ public Object convert(Object value)
*/
public Object deconvert(Object value)
{
- if (value == null) return 0;
+ if (value == null) return null;
Review comment:
this was dead code before, but returning 0 was never safe as you don't
know if the inputType was int or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
