smiklosovic commented on code in PR #1351:
URL: https://github.com/apache/cassandra/pull/1351#discussion_r853322763
##########
src/java/org/apache/cassandra/service/StartupCheck.java:
##########
@@ -43,16 +43,25 @@
*
* @param startupChecksOptions all options from descriptor
* @throws org.apache.cassandra.exceptions.StartupException if the test
determines
- * that the environement or system is not in a safe state to startup
+ * that the
environement or system is not in a safe state to startup
*/
void execute(StartupChecksOptions startupChecksOptions) throws
StartupException;
/**
- *
* @return type of this startup check for configuration retrieval
*/
default StartupCheckType getStartupCheckType()
{
return StartupCheckType.non_configurable_check;
}
+
+ /**
+ * Executes abritrary logic only after all startup checks are passed.
+ *
+ * These methods, per check, will be executed in the same order as checks
were.
+ *
+ * @param startupChecksOptions all options from descriptor
+ * @throws StartupException exception thrown in case post-check task is
errorneous
+ */
+ default void executePostCheckTask(StartupChecksOptions
startupChecksOptions) throws StartupException {}
Review Comment:
Maybe there is more appropriate place to schedule that heartbeating task to
periodic executor, maybe later in the boot process, just before we start to
accept new connections from clients, not sure about that. So this logic might
go away completely. Do you know about more appropriate place to schedule it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
