smiklosovic commented on code in PR #1351: URL: https://github.com/apache/cassandra/pull/1351#discussion_r853339360
########## conf/cassandra.yaml: ########## @@ -1687,4 +1687,8 @@ drop_compact_storage_enabled: false # enabled: true # (overriden by cassandra.ignore_dc system property) # rack: # enabled: true # (overriden by cassandra.ignore_rack system property) - +# gc_grace_period: Review Comment: > users do not need to read documentation to understand what a startup check does, it should be straightforward to understand this from the check name: > > check_dc: verify if dc is valid check_rack: verify if rack is valid check_data_resurrection: verify if there was data resurrection Again you need to look at this from perspective - it is in some section called "startup_checks". That key "dc" or "rack" does not live alone, it is inherently connected to the section it is in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org
