jonmeredith commented on code in PR #1758:
URL: https://github.com/apache/cassandra/pull/1758#discussion_r931539651


##########
conf/cassandra.yaml:
##########
@@ -992,6 +992,8 @@ compaction_throughput: 64MiB/s
 # are completely written, and used in place of the prior sstables for
 # any range that has been written. This helps to smoothly transfer reads 
 # between the sstables, reducing page cache churn and keeping hot rows hot
+# Set sstable_preemptive_open_interval to null for disabled which is 
equivalent to the sstable_preemptive_open_interval_in_mb
+# being negative

Review Comment:
   > I hope I didn't misunderstood your question.
   I was asking if `sstable_preemptive_open_interval_in_mb` could set a new 
`sstable_preemptive_open_enabled` entry as well as 
`sstable_preemptive_open_interval`.
   
   If you have a fix for setting `null` and don't need to create an `enabled` 
flag I'm fine with that. I thought you were saying you might need to create on 
to resolve this problem.



##########
conf/cassandra.yaml:
##########
@@ -992,6 +992,8 @@ compaction_throughput: 64MiB/s
 # are completely written, and used in place of the prior sstables for
 # any range that has been written. This helps to smoothly transfer reads 
 # between the sstables, reducing page cache churn and keeping hot rows hot
+# Set sstable_preemptive_open_interval to null for disabled which is 
equivalent to the sstable_preemptive_open_interval_in_mb
+# being negative

Review Comment:
   > I hope I didn't misunderstood your question.
   
   I was asking if `sstable_preemptive_open_interval_in_mb` could set a new 
`sstable_preemptive_open_enabled` entry as well as 
`sstable_preemptive_open_interval`.
   
   If you have a fix for setting `null` and don't need to create an `enabled` 
flag I'm fine with that. I thought you were saying you might need to create on 
to resolve this problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to